Implement getColumnDescription getter #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surchs
changed the base branch from
master
to
dev_components_talk_to_store_directly
I ran into a weird problem where I was not able to wrap the commit method on the store object in a cypress spy, only when the test ran after another test. I assume that running the other test somehow changed the store object. Re-initializing the mocked store object with beforeEach fixed this.
surchs
force-pushed
the
surchs/issue253
branch
from
4d1eadd
to
6c15c6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bit more in this PR than just the normal refactor. The reason is that adding a new test for the
column-linking-componentsomehow broke the existing component test in a way I didn't understand.The original
column-linking-componenttest passed when forced to run aloneit.only, but could not wrap thecommitfunction on thestoreobject in acy.spywhen it was run second after the new test.I think this may be because running the first test somehow changes the mocked
storeobject in a waythat affects subsequent test. I was not able to debug this though, the
storeobject looked normal to me.As a workaround, I have moved the mocked store into a
beforeEachstatement to make sure every testgets passed the same
storeobject.There may be better ways of doing this, and I think we should research these separately. I made #288 to track this.
Closes #253