Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components and their tests are nominally refactored for store #323

Merged
merged 4 commits into from
Jan 24, 2023
Merged

Components and their tests are nominally refactored for store #323

merged 4 commits into from
Jan 24, 2023

Conversation

jarmoza
Copy link
Contributor

@jarmoza jarmoza commented Jan 24, 2023

Closes #322

@jarmoza jarmoza requested a review from surchs January 24, 2023 21:23
surchs
surchs approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @jarmoza 🎉

@jarmoza jarmoza merged commit addabdf into dev_components_talk_to_store_directly Jan 24, 2023
@jarmoza jarmoza deleted the jarmoza-components-look-right branch January 31, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jarmoza @surchs