-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase 2 Refactor: Missing values functionality + integration with Annotation page #382
Merged
jarmoza
merged 10 commits into
dev_components_talk_to_store_directly
from
jarmoza-missingvalues-cleanup
Mar 22, 2023
Merged
Phase 2 Refactor: Missing values functionality + integration with Annotation page #382
jarmoza
merged 10 commits into
dev_components_talk_to_store_directly
from
jarmoza-missingvalues-cleanup
Mar 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarmoza
added
annotation page
maint:refactor
Simplifying or restructuring existing code or documentation.
labels
Mar 21, 2023
rmanaem
reviewed
Mar 21, 2023
rmanaem
reviewed
Mar 21, 2023
@rmanaem Changes pushed. |
rmanaem
approved these changes
Mar 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👨🍳
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #381 along with a few adjustments for the missing values refactor. There is also some cleanup - removal of now-extraneous functions, removal of old comments, and updates to relevant unit tests
annot-continuous-values.vue
annot-continuous-values
componentannot-missing-values.cy.js
getValueDescription
)store-getter-getMissingValues.cy.js
missingValues
key in the data dictionary is initialized (seeindex.js
for more info)store-mutation-initializeDataDictionary.cy.js
annotation.vue
index.js
missingValues
for columns indataDictionary.annotated
are now initialized insideinitializeDataDictionary
. The reasoning behind this is that this results in cleaner code down the line where we don't have to continually check for themissingValues
list's existencedataDictionary.annotated
are now reverted to their default/userProvided
values + new emptymissingValues
list