-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Categorical Select bugfix + Rework of initialization of data dictionary columns for data types #395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested two changes.
Regarding the docstring change, feel free to remove it if you think its presence is unnecessary.
Co-authored-by: Arman Jahanpour <77515879+rmanaem@users.noreply.github.com>
@rmanaem Changes committed. Take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👨🏼🍳
This PR addresses both #386 and #390. A list of changes made by file below.
annot-categorical.vue
label
attribute forv-select
as it was unnecessary and producing a warning.value
is used for showing what was just selected and retrieving what had been selected upon component re-mountselectOptionAndUpdate
as we would like to avoid multiline attribute codeannot-continuous-values.vue
selectHeuristic
as we would like to avoid multiline attribute codeindex.js
Formatting/streamlining
getColumnDescription
,getHarmonizedPreview
implementationupdateAnnotationCount
- Updated this function for a clean check of data type for the column followed by the annotation condition. This way we do not have to worry about cascading conditions.Feature 390 - Initialization of specialized structures for data types
alterColumnCategoryMapping
- this has been rewritten to allow for the addition of special structurestransformationHeuristic
andvalueMap
indataDictionary.annotated.<column-name>
. Determination of which should be added is dependent on the category assigned to each column indataDictionary.annotated.<column-name>
.getHeuristic
- transformationHeuristic property will now always be present for continuous values-categorized columnsBug fix 386
getSelectedCategoricalOption
- used to determine via lookup of storedidentifier
invalueMap
what the label for that identifier isselectCategoricalOption
- 1) Deletes values from the value map for categorical columns if the annotated value is removed (blank vue select),and 2) Changes/adds the annotated value to the
valueMap
when an option is selected from the vue-select inannot-categorical
setHeuristic
- Either adds the heuristic from the drop down or deletes the heuristic for a column inannot-continuous-values
Test updates for the fix and feature
store-getter-getHeuristic.cy.js
store-getter-getSelectedCategoricalOption.cy.js
store-mutation-selectCategoricalOption.cy.js
store-mutation-updateAnnotationCount.cy.js
Any string referring to data table column in the repo now is called
columnName
alterColumnCategoryMap.cy.js
column-linking-table.cy.js
annot-continuous-values.cy.js
annot-columns.cy.js
column-linking-table.vue
(In addition attributes for theb-table
have been reordered.)annot-columns.vue