Refactored e2e tests #405
Merged
Refactored e2e tests #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Apr 17, 2023
surchs
requested changes
Apr 18, 2023
There was a problem hiding this comment.
Very cool! Congrats @rmanaem and @jarmoza on getting us back to green on the end to end tests. That's a big milestone 🎉 !
I mostly have 🍒 in the comments, but there are a couple of leftover debug statements I think you should take out. I also noted a couple of places where a clarifying comment will save a reader some time in understanding why a particular thing is done in the tests.
|
@jarmoza Have you made any changes to the code since my last commit? |
rmanaem
force-pushed
the
jarmoza-e2e-refactor
branch
from
301dff5
to
7ccdbb8
Compare
- Updated `data-cy` references in `cy.get` statements - Removed use of `Save Annotation` button as the button itself has been removed - Commented out `tool group` test cases
rmanaem
force-pushed
the
jarmoza-e2e-refactor
branch
from
7ccdbb8
to
b3de285
Compare
jarmoza
merged commit be37a6b
into
dev_components_talk_to_store_directly
3 checks passed
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
loadAppStateannotation-pagtests.cy.jssimple-e2etests.cy.jsCloses #332 #333 #341