-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Restore download functionality for refactor/new meta getter #433
[ENH] Restore download functionality for refactor/new meta getter #433
Conversation
…nload-functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very exciting milestone @jarmoza 🎉. We definitely need to celebrate this big achievement with everyone, especially @rmanaem!
The PR looks good, my comments are mostly 🍒 or thoughts. Take a look and decide, then good to squash merge 🧑🍳
Once you do, please directly open the next PR to merge dev_...
into master
! We can deal with any required rebasing in that other PR then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
One thing I'm noticing here is that because all of the getters have to be stubbed, I'm not sure what we'll do once we encounter some weird edge cases that we'll also want to test. If every one of these needs it's own setup and each setup will be as long as this one, tests may get a bit hard to read.
But for now this reads well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be beyond an aesthetic issue actually. Something I've noticed is that debugging the getters if they are plugged in via the import from index.js
is not available via console-style debugging. And in fact, it seems that beforeEach
is working in a different or at least at a different time to properly setup the variables for each test. I've noticed there's a difference between assigning getters to store.state.getters
in beforeEach
vs. inside of a test. This is something that should be documented in our Cypress wiki as well.
Closes #427
Closes #416
Fixes #172
Changes proposed in this pull request:
getJsonOutput
dataDictionary.filename
to (re)use for the new output json filegetJsonOutput
with mocks for its getters. This overcomes an issue where calling a getter from a getter worked one way in e2e/manual testing but not in unit testing and vice versa.