-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add environment variable for allowed origins for CORS #151
Conversation
Pull Request Test Coverage Report for Build 6039803111
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @alyssadai. Everything functional is looking good! I still requested changes to make sure we communicate our expectations for CORS clearly to the user - I left some minor comments on where I think we should clarify things.
Take a look and let me know what you think. Then I think this can go
Co-authored-by: Sebastian Urchs <surchs@users.noreply.github.com>
…m/neurobagel/api into iss-150/configurable-CORS-origins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good @alyssadai, 🧑🍳
Closes #150
Changes proposed in this pull request:
NB_API_ALLOWED_ORIGINS
replaces hard-coded wildcard allowing all origins for CORSChecklist
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see https://neurobagel.org/contributing/pull_requests for more info)Closes #XXXX
For new features:
For bug fixes: