-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Implemented NB_FEDERATE_REMOTE_PUBLIC_NODES
env var
#90
Conversation
Pull Request Test Coverage Report for Build 9274359452Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rmanaem, this seems to do the trick. I do think we should
- provide basic docs for this new feature. if README isn't the place, then please make a PR against the ENV var table in the main docs and link here
- add a basic integration test to make sure the ENV var does what we think it does
unless I forgot, this is our first use of ENV vars in this tool. So let's add atemplate.env
with the new variable and a short docstring explaining what it does.
edit: I may be misremembering what the default was for providing template.env
files in the repos themselves. But we should document the ENV var in the main docs, and ideally also as a docker run
example in the README so I can get started quick. let me know what you think
NB_FEDERATE_REMOTE_PUBLIC_NODES
env varNB_FEDERATE_REMOTE_PUBLIC_NODES
env var
Addressing that here neurobagel/recipes#60
Test has been added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thanks @rmanaem. This looks good
🧑🍳
🚀 PR was released in |
Checklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
For new features:
For bug fixes: