Skip to content
This repository has been archived by the owner on Mar 9, 2024. It is now read-only.

[ENH] Implemented logic to allow expansion of long dataset names #282

Merged
merged 4 commits into from
Nov 17, 2023

Conversation

rmanaem
Copy link
Collaborator

@rmanaem rmanaem commented Nov 16, 2023

Changes proposed in this pull request:

  • Added a <span> and a condition to truncate/expand the title of a card with a dataset name with more than 60 characters
  • Added test for card title expansion

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for neurobagel-query-tool ready!

Name Link
🔨 Latest commit 933984c
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query-tool/deploys/65576eb97c0e8d0008e74586
😎 Deploy Preview https://deploy-preview-282--neurobagel-query-tool.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surchs surchs self-requested a review November 16, 2023 20:11
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, couple 🍒 comments, then 🧑‍🍳

cypress/component/ResultCard.cy.js Outdated Show resolved Hide resolved
cypress/component/ResultCard.cy.js Outdated Show resolved Hide resolved
components/ResultCard.vue Show resolved Hide resolved
cypress/component/ResultCard.cy.js Outdated Show resolved Hide resolved
@rmanaem rmanaem merged commit b31527f into main Nov 17, 2023
8 checks passed
@rmanaem rmanaem deleted the feat-165 branch November 17, 2023 13:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Expand long dataset titles from ellipses
2 participants