Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Remove attributes with a NULL label #124

Merged
merged 3 commits into from
Apr 12, 2024
Merged

[FIX] Remove attributes with a NULL label #124

merged 3 commits into from
Apr 12, 2024

Conversation

surchs
Copy link
Contributor

@surchs surchs commented Apr 12, 2024

This is not a great fix - but better than having the app crash under us

Changes proposed in this pull request:

  • filter any attribute with a label: null
  • display a warning
  • add a (basic) regression test

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

This is not a great fix - but better than having the app
crash under us
Copy link

netlify bot commented Apr 12, 2024

Deploy Preview for neurobagel-query ready!

Name Link
🔨 Latest commit 5392523
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query/deploys/661949bee10eb60008285da5
😎 Deploy Preview https://deploy-preview-124--neurobagel-query.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surchs surchs marked this pull request as ready for review April 12, 2024 13:29
@rmanaem rmanaem self-requested a review April 12, 2024 14:30
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@rmanaem rmanaem added the pr-bug-fix Bug fix, will increment patch version when merged (0.0.+1) label Apr 12, 2024
Co-authored-by: Arman Jahanpour <77515879+rmanaem@users.noreply.github.com>
@surchs surchs merged commit 439bc21 into main Apr 12, 2024
9 checks passed
@surchs surchs deleted the hotfix branch April 12, 2024 15:02
@surchs
Copy link
Contributor Author

surchs commented Apr 15, 2024

🚀 PR was released in v0.2.1 🚀

@surchs surchs added the released This issue/pull request has been released. label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bug-fix Bug fix, will increment patch version when merged (0.0.+1) released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query tool fails when attribute responses include a label of null
2 participants