Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] Removed trailing slash from queryURL #235

Merged
merged 5 commits into from
Aug 2, 2024
Merged

[MNT] Removed trailing slash from queryURL #235

merged 5 commits into from
Aug 2, 2024

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Jul 30, 2024 •
edited
Loading

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@rmanaem rmanaem requested a review from alyssadai July 30, 2024 18:08
@netlify Netlify
Copy link

netlify bot commented Jul 30, 2024 •
edited
Loading

✅ Deploy Preview for neurobagel-query ready!

Name Link
🔨 Latest commit 14f3467
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query/deploys/66acef8fef7fa10008aacd67
😎 Deploy Preview https://deploy-preview-235--neurobagel-query.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmanaem rmanaem added the pr-patch Incremental feature improvement, will increment patch version when merged (0.0.+1) label Jul 30, 2024
@alyssadai alyssadai mentioned this pull request Jul 31, 2024
Merged
7 tasks
alyssadai
alyssadai approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@alyssadai alyssadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@rmanaem rmanaem added the release Create a release when this PR is merged label Aug 2, 2024
@rmanaem rmanaem merged commit 0c38fc3 into main Aug 2, 2024
9 checks passed
@rmanaem rmanaem deleted the maint-234 branch August 2, 2024 14:41
@neurobagel-bot Neurobagel Bot
Copy link
Contributor

neurobagel-bot bot commented Aug 2, 2024

🚀 PR was released in v0.3.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssadai alyssadai alyssadai approved these changes

Assignees
No one assigned
Labels
pr-patch Incremental feature improvement, will increment patch version when merged (0.0.+1) release Create a release when this PR is merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove slashes before query parameters in request URLs
2 participants
@rmanaem @alyssadai