Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Implementation of the Unsupervised Tree model using TwoMeans, Best splitting and depth/best building #9

Merged
merged 56 commits into from
Jan 25, 2023

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Jan 24, 2023

Initializes the bulk of the work for #6
Closes: #7

All this work builds off of the scikit-learn PR branch in: scikit-learn/scikit-learn#25448

Changes proposed in this pull request:

  • Introduces the necessary build and test pipeline for developing the tree and forest models
    - Fully tests the meson and dev.py development sequence (i.e. run dev.py build and then dev.py test
  • Introduces the UnsupervisedDecisionTree model, which can act as a transformer and clusterer
  • Introduces the UnsupervisedRandomForest model, which is an ensemble of UnsupervisedDecisionTrees
  • Copies over the relevant code and then removes relevant LOC

Note:

  • Maintaining this will be challenging because there are a few LOC differences in the Tree builder specifically, since we do not use y anymore
  • We can refactor the Python Tree/Forest code once the necessary refactoring to BaseDecisionTree are made

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

@adam2392
Copy link
Collaborator Author

Segfaults going on...

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 changed the title Unsup [ENH] Implementation of the Unsupervised Tree model using TwoMeans, Best splitting and depth/best building Jan 25, 2023
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 merged commit 39ba572 into main Jan 25, 2023
@adam2392 adam2392 deleted the unsup branch January 25, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants