Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOGNAME env should be set #725

Closed
seidler2547 opened this issue Apr 4, 2017 · 1 comment
Closed

LOGNAME env should be set #725

seidler2547 opened this issue Apr 4, 2017 · 1 comment

Comments

@seidler2547
Copy link

In sesman/env.c, the environment variable LOGNAME should be set to the same value as USER. I checked the source code of other X login managers, and it is being set there. There was even a bug in Firefox that makes Firefox crash when this isn't set.
@metalefty
Copy link
Member

+1
I was suffering from the Firefox bug. It is finally fixed since Firefox 52.0.2 but I agree that LOGNAME environment variable should be set.

metalefty added a commit to metalefty/xrdp that referenced this issue Apr 4, 2017
@metalefty
sesman: LOGNAME should be set to username
32f2a9e 
which is used to store login name. The login name shall be the string
that would be returned by the getlogin() function [1]. Some applications
only refers LOGNAME environment variable and don't fallback to other
variables such as USER.

Fixes neutrinolabs#725.  Reported by @seidler2547.

[1] The Single UNIX Specification, Issue 7
@metalefty metalefty mentioned this issue Apr 4, 2017
Merged
metalefty added a commit that referenced this issue Apr 6, 2017
@metalefty
sesman: LOGNAME should be set to username
06ce0d7 
which is used to store login name. The login name shall be the string
that would be returned by the getlogin() function [1]. Some applications
only refers LOGNAME environment variable and don't fallback to other
variables such as USER.

Fixes #725.  Reported by @seidler2547.

[1] The Single UNIX Specification, Issue 7
metalefty added a commit to metalefty/xrdp that referenced this issue May 9, 2017
@metalefty
sesman: LOGNAME should be set to username
8ea01f3 
which is used to store login name. The login name shall be the string
that would be returned by the getlogin() function [1]. Some applications
only refers LOGNAME environment variable and don't fallback to other
variables such as USER.

Fixes neutrinolabs#725.  Reported by @seidler2547.

[1] The Single UNIX Specification, Issue 7
@metalefty metalefty mentioned this issue May 9, 2017
Merged
metalefty added a commit that referenced this issue May 12, 2017
@metalefty
sesman: LOGNAME should be set to username
2b18141 
which is used to store login name. The login name shall be the string
that would be returned by the getlogin() function [1]. Some applications
only refers LOGNAME environment variable and don't fallback to other
variables such as USER.

Fixes #725.  Reported by @seidler2547.

[1] The Single UNIX Specification, Issue 7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seidler2547 @metalefty