Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing posts with reply quotes is wonky #89

Closed
antialiasis opened this issue Aug 1, 2015 · 5 comments
Closed

Editing posts with reply quotes is wonky #89

antialiasis opened this issue Aug 1, 2015 · 5 comments

Comments

@antialiasis
Copy link

(I'm on Firefox; don't know if it matters, but.)

Steps to reproduce:

  1. Use the reply-to-a-reply feature to reply to a reply. This opens up the editor, with "[username] replied to your post: [post title]" and then a blockquote with the user's reply. I can type an answer below it and post it just fine.
  2. Now edit the resulting post. Problem 1: suddenly "[username]", "replied to your", "post", ":" and "[post title]" are all separate paragraphs (presumably, what's actually happening is each HTML element is getting wrapped in a paragraph). This has been happening for a while with the old xkit.
  3. Fix that so that the "replied to your post" stuff is one line above the quote again (presumably a sensible thing for people to do under the circumstances), then save the post.
  4. Press the edit button on the post again. Problem 2: Suddenly, both the "replied to your post" line and the blockquote have disappeared, and if you save they will be permanently gone. This one seems to be recent? I only just installed New XKit in the hope it would fix it, but alas.
@wuggen
Copy link

wuggen commented Aug 9, 2015

Same issue here, same steps to reproduce, although I don't know how long it's been like this for me. Firefox 39.0.3, other installed browser extensions:

  • Adblock Plus 2.6.10 (disabled on tumblr)
  • Blur 4.9.1728
  • Stylish 2.0.2.1 (but only one style to disable PNG transparency when viewing an image alone)
  • EPUBReader 1.5.0.6.1
  • RAMBack 1.0.1
  • Video DownloadHelper 5.3.1.1
    (I don't imagine those last three are likely to cause conflicts, but for the sake of thoroughness I listed them.)
    Default Firefox theme.

Some XKit stuff:

  • In the One-Click Reply extension, I have Show Avatars, Open In New Tab, Multiple Reply, and Tag By Usernames enabled.
  • Editable Reblogs is enabled.

Hopefully some of that is relevant. If not, or you just need more info, my tumblr URL is theunderdog09. Best to contact me there.

@WyohKnott
Copy link

I reproduced it too. I think it's because of the way we fetch the HTML for creating the reply, we keep all the styling HTML tags like <span class="activity"> but Tumblr strips away automatically additional "not allowed" tags when saving the post, and either replace them with br/p or strip the content of said tag.

@invalidCards
Copy link
Member

Closing since replies have been removed and this issue can no longer occur.

@nightpool
Copy link
Member

@thepsionic ocr is still a thing though, and this can affect any
notification type

On Sun, Aug 9, 2015 at 5:05 AM TheUnderdog09 notifications@github.com
wrote:

Same issue here, same steps to reproduce, although I don't know how long
it's been like this for me. Firefox 39.0.3, other installed browser
extensions:

  • Adblock Plus 2.6.10 (disabled on tumblr)
  • Blur 4.9.1728
  • Stylish 2.0.2.1 (but only one style to disable PNG transparency when
    viewing an image alone)
  • EPUBReader 1.5.0.6.1
  • RAMBack 1.0.1
  • Video DownloadHelper 5.3.1.1 (I don't imagine those last three are
    likely to cause conflicts, but for the sake of thoroughness I listed them.)
    Default Firefox theme.

Some XKit stuff:

  • In the One-Click Reply extension, I have Show Avatars, Open In New
    Tab, Multiple Reply, and Tag By Usernames enabled.
  • Editable Reblogs is enabled.

Hopefully some of that is relevant. If not, or you just need more info, my
tumblr URL is theunderdog09. Best to contact me there.


Reply to this email directly or view it on GitHub
#89 (comment).

@invalidCards
Copy link
Member

@nightpool I forgot about that. Anyway, I just tested it, and it doesn't seem to bug out anymore; @antialiasis @TheUnderdog09 @WyohKnott If you still experience this issue feel free to re-open it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants