Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrated @newrelic/aws-sdk into agent repo #2161

Merged
merged 554 commits into from Apr 24, 2024

Conversation

bizob2828
Copy link
Member

Description

Aside from moving code, I got rid of access to specs via shim.specs, access a symbol on shim and instead use the symbols directly. I also separated versioned tests into v2 and v3 folders and added targets for compatibility report.

Related Issues

Closes #2125

garbados and others added 30 commits January 6, 2022 16:10
Fixes nr-hooks version checking circular reference issue.
changing gh token to the org level value
…040ce2b72237fec9264bb8

[Snyk] Upgrade newrelic from 8.7.0 to 8.7.1
Resolves several dev npm audit warnings.
Bumps [moment](https://github.com/moment/moment) from 2.29.1 to 2.29.2.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](moment/moment@2.29.1...2.29.2)

---
updated-dependencies:
- dependency-name: moment
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…/moment-2.29.2

Bump moment from 2.29.1 to 2.29.2
Bumps tap and resolves audit warnings
bizob2828 and others added 20 commits February 28, 2024 15:13
Co-authored-by: jsumners-nr <gh-actions-jsumners-nr@github.com>
Co-authored-by: svetlanabrennan <gh-actions-svetlanabrennan@github.com>
…c#277)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jsumners-nr <gh-actions-jsumners-nr@github.com>
Co-authored-by: James Sumners <jsumners@newrelic.com>
Copy link
Contributor

@jsumners-nr jsumners-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Just a few tweaks needed.

lib/instrumentation/aws-sdk/nr-hooks.js Outdated Show resolved Hide resolved
lib/instrumentation/aws-sdk/v2/core.js Outdated Show resolved Hide resolved
lib/instrumentation/aws-sdk/v2/dynamodb.js Outdated Show resolved Hide resolved
lib/instrumentation/aws-sdk/v3/bedrock.js Outdated Show resolved Hide resolved
lib/instrumentation/aws-sdk/v3/common.js Outdated Show resolved Hide resolved
lib/instrumentation/aws-sdk/v3/common.js Outdated Show resolved Hide resolved
lib/instrumentation/aws-sdk/v3/dynamodb.js Outdated Show resolved Hide resolved
lib/instrumentation/aws-sdk/v3/sns.js Outdated Show resolved Hide resolved
lib/instrumentation/aws-sdk/v3/sqs.js Outdated Show resolved Hide resolved
Copy link
Contributor

@jsumners-nr jsumners-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bizob2828 bizob2828 merged commit a9eb593 into newrelic:main Apr 24, 2024
22 checks passed
Node.js Engineering Board automation moved this from Needs PR Review to Done: Issues recently completed Apr 24, 2024
@bizob2828 bizob2828 deleted the add-aws-sdk branch April 24, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Node.js Engineering Board
  
Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

Migrate @newrelic/aws-sdk into repo
9 participants