Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ppdsc 388 newskit sharebar #2339

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Conversation

parkjh
Copy link
Contributor

@parkjh parkjh commented Oct 15, 2019

@parkjh parkjh force-pushed the feat-ppdsc-388-newskit-sharebar branch 8 times, most recently from 1524fd9 to 626d234 Compare October 15, 2019 17:16
Copy link
Contributor

@ValGeorgiev ValGeorgiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a kind suggestion.. we need to be more careful introducing newskit to times-components and not changing any existing functionality. We have good test coverage in render, but this will show up when we are upgrading TC packages in render. Our main priority in TNL is to release article page on react and any additional changes in the current implementation and potential regression issues will slow us. Otherwise, good work !

@parkjh parkjh force-pushed the feat-ppdsc-388-newskit-sharebar branch 4 times, most recently from 112e71b to 0e8ad8c Compare October 16, 2019 10:57
@parkjh parkjh force-pushed the feat-ppdsc-388-newskit-sharebar branch from 0e8ad8c to 6b86104 Compare October 16, 2019 12:51
This was referenced Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants