-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ppdsc 388 newskit sharebar #2339
Conversation
1524fd9
to
626d234
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a kind suggestion.. we need to be more careful introducing newskit to times-components and not changing any existing functionality. We have good test coverage in render, but this will show up when we are upgrading TC packages in render. Our main priority in TNL is to release article page on react and any additional changes in the current implementation and potential regression issues will slow us. Otherwise, good work !
112e71b
to
0e8ad8c
Compare
0e8ad8c
to
6b86104
Compare
see https://nidigitalsolutions.jira.com/browse/PPDSC-388