Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

所蔵の編集画面:借りられている本を除籍できてしまう(借りた状態のまま、除籍処理されてしまう) #790

Closed
2 tasks done
yegusa opened this issue Sep 28, 2015 · 6 comments

Comments

@yegusa
Copy link

yegusa commented Sep 28, 2015

借りた状態のまま、除籍処理されてしまう。
借りた状態のものは、「除籍」しようとしたら、
「この本は借りられています。返却処理をしてから除籍してください」
というようなエラーをだして、除籍できないようにするべき。

借りる前:
image

image

image

借りた後:
http://dev.next-l.jp/checkouts
image

image

image

image

除籍処理する
image

除籍処理した後
image

image

image

開発サーバーで確認しました。 http://dev.next-l.jp/
enju_biblio: 0.1.0.pre69
enju_circulation: 0.1.0.pre48
enju_event: 0.1.17.pre26
enju_flower: 0.1.0.pre23
enju_leaf: 1.1.0.rc21
enju_library: 0.1.0.pre44
enju_manifestation_viewer: 0.1.0.pre19
enju_message: 0.1.14.pre25
enju_ndl: 0.1.0.pre37
enju_oai: 0.1.0.pre19
enju_subject: 0.1.0.pre33

@yegusa yegusa added the bug label Sep 28, 2015
@yegusa yegusa added this to the 1.1.1.rc1 milestone Sep 28, 2015
@yegusa yegusa modified the milestones: 1.1.0, 1.1.1.rc1 Sep 28, 2015
@yegusa yegusa changed the title 借りられている本を除籍できてしまう(借りた状態のまま、除籍処理されてしまう) 所蔵の編集画面:借りられている本を除籍できてしまう(借りた状態のまま、除籍処理されてしまう) Sep 28, 2015
@yegusa yegusa modified the milestones: 1.1.0, 1.1.1.rc1 Sep 28, 2015
@nabeta nabeta modified the milestones: 1.2.0.beta.4, 1.2.1 Aug 20, 2016
@nabeta
Copy link
Member

nabeta commented Aug 20, 2016

@yegusa 除籍メニューが別にできたので、この画面で「除籍済み」を選択できないようにするのがよいと思うのですが、いかがでしょうか。

@nabeta nabeta modified the milestones: 1.2.0.beta.4, 1.2.x Oct 16, 2016
@yegusa yegusa modified the milestones: 1.2.x, 1.2.0 Oct 16, 2016
@nabeta nabeta modified the milestones: 1.2.0, 1.2.x Nov 11, 2016
@nabeta
Copy link
Member

nabeta commented May 2, 2019

このケースは貸し出されたまま紛失->除籍、に相当しませんでしょうか。実際には返却されていないのに返却処理をするのは不自然だと思います。

nabeta added a commit to next-l/enju_circulation that referenced this issue Dec 21, 2019
nabeta added a commit to next-l/enju_circulation that referenced this issue Dec 21, 2019
nabeta added a commit to next-l/enju_circulation that referenced this issue Dec 21, 2019
nabeta added a commit to next-l/enju_circulation that referenced this issue Dec 21, 2019
nabeta added a commit to next-l/enju_circulation that referenced this issue Dec 21, 2019
nabeta added a commit to next-l/enju_circulation that referenced this issue Dec 21, 2019
nabeta added a commit to next-l/enju_circulation that referenced this issue Dec 21, 2019
nabeta added a commit to next-l/enju_circulation that referenced this issue Dec 21, 2019
nabeta added a commit to next-l/enju_circulation that referenced this issue Dec 21, 2019
@nabeta
Copy link
Member

nabeta commented Dec 21, 2019

予約されている場合は貸出状態に「除籍済み」を選択しようとするとエラーにするようにしました。
https://enju.next-l.jp/items/7443
スクリーンショット 2019-12-22 1 10 13

nabeta added a commit to next-l/enju_circulation that referenced this issue Dec 24, 2019
nabeta added a commit to next-l/enju_circulation that referenced this issue Dec 24, 2019
nabeta added a commit to next-l/enju_circulation that referenced this issue Dec 24, 2019
nabeta added a commit to next-l/enju_circulation that referenced this issue Dec 25, 2019
nabeta added a commit to next-l/enju_circulation that referenced this issue Dec 25, 2019
nabeta added a commit to next-l/enju_circulation that referenced this issue Dec 25, 2019
nabeta added a commit to next-l/enju_circulation that referenced this issue Dec 25, 2019
@masao
Copy link
Member

masao commented Feb 16, 2020

修正を確認しました。クローズします。

@yegusa
Copy link
Author

yegusa commented Apr 19, 2021

マニュアル修正については #791 (comment) を参照のこと

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants