Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heoseungjun/java-racingcar #5237

Merged
merged 1 commit into from
Mar 5, 2024
Merged

heoseungjun/java-racingcar #5237

merged 1 commit into from
Mar 5, 2024

Conversation

dev-domo
Copy link

@dev-domo dev-domo commented Mar 5, 2024

StringTest 및 SetCollectionTest 구현

Copy link

@csh0034 csh0034 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요. 승준님!
자동차 경주 미션을 함께하게 된 최승훈입니다.

1단계 잘 진행해 주셔서 바로 머지 하겠습니다 💯
코멘트 한가지 남겨두었는데 다음단계 진행전에
고민해보시면 좋을것 같아요!

미션을 진행하면서 궁금하신 사항 있으시면
편하게 DM 주세요 😄

@DisplayName("문자열에서 특정 위치의 문자를 확인하고 인덱스를 벗어나면 오류를 발생시킨다")
@ParameterizedTest
@ValueSource(strings = {"abc"})
void charAtTest(String text) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예외를 발생시키는 부분을 객체를 직접만들어 throw 하는것이 아닌
요구사항에 맞춰 abc 라는 문자열의 길이보다 큰 index 로 charAt() 을 호출했을때
예외가 발생하는 부분을 검증해보면 좋을것 같아요!

}

@ParameterizedTest
@ValueSource(ints = {1,2,3})
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ValueSource 사용 👍

@csh0034 csh0034 merged commit c867c8a into next-step:heoseungjun Mar 5, 2024
@dev-domo dev-domo deleted the step1 branch March 7, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants