2단계 - 지뢰 찾기(지뢰 개수) #378
Merged
2단계 - 지뢰 찾기(지뢰 개수) #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MyStoryG
requested changes
Nov 30, 2023
src/main/kotlin/minesweeper/Mines.kt
Outdated
| private val mines: Set<Position> | ||
| ) { | ||
|
|
||
| fun nearIncrementCellNumber(board: Array<Array<Int>>): Array<Array<Int>> { |
There was a problem hiding this comment.
함수명은 보통 동사로 시작하니 다른 함수명처럼 통일성을 맞추면 좋을 것 같아요.
src/main/kotlin/view/Output.kt
Outdated
Comment on lines
19
to
38
| minesweeperBoard.toBooleanBoard() | ||
| minesweeperBoard.calculateAdjacentMineCounts() | ||
| .joinToString("\n") { fillingCell(it) } | ||
|
|
||
| private fun fillingCell(row: Array<Boolean>) = | ||
| row.joinToString(" ") { if (it) MINE else CELL } | ||
| private fun fillingCell(row: Array<Int>) = | ||
| row.joinToString(" ") { if (it < 0) MINE else it.toString() } |
There was a problem hiding this comment.
이런 부분에서 발생한 변경을 추후에 줄일 수 있는 방법은 어떤 것이 있을까요?
기존에 C와 *로 표시하던 것을 숫자와 *로 변경하면서 이 부분이 수정되었습니다.
여러 방법이 있을 수 있겠지만 한 가지 떠올려 보자면 MinesweeperBoard를 어떠한 방법을 통해서 잘 구성해 보면 되지 않을까요?
OCP (개방폐쇄의 원칙: Open Close Principle): 소프트웨어의 구성요소(컴포넌트, 클래스, 모듈, 함수)는 확장에는 열려있고, 변경에는 닫혀있어야 한다.
There was a problem hiding this comment.
GameBoard를 추상화하여 게임판을 렌더링하는 책임을 가진 클래스를 추가해봤습니다 ㅎㅎ
1. GameBoard 인터페이스 추가 2. 렌더링 책임을 가지는 CharBoard와 NumberBoard 구현체 추가 3. 게임판 요소 BoardDimensions 클래스 추가
MyStoryG
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 ㅎㅎ 2단계 리뷰도 잘 부탁드립니다!!
이전에 피드백 주셨던 부분도 수정해봤습니다
게임판을 만드는 책임들이 잘 나뉘어진건지 궁금하네요 ㅎㅎ