Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonsensical bookmark count #2202

Closed
InfamousUser opened this issue Aug 4, 2024 · 6 comments
Closed

Nonsensical bookmark count #2202

InfamousUser opened this issue Aug 4, 2024 · 6 comments
Labels

Comments

@InfamousUser
Copy link

Describe the bug
A bookmark folder has more bookmarks than all the bookmarks on the server

To Reproduce
Steps to reproduce the behavior:

  1. Have a number of bookmarks uploaded.
  2. Open the bookmarks app.
  3. Look at the bookmarks count

Expected behavior
All of the bookmarks contained within the bookmarks app should not be more than the total number of bookmarks.

Screenshots
image

Desktop (please complete the following information):

  • OS: Ubuntu Linux
  • Browser: Firefox
  • Version: 128.0.3

Server (please complete the following information):

  • OS: Ubuntu Linux
  • HTTP server: Apache 2
  • Database: Postgresql
  • PHP version: 8.1
  • Nextcloud version: 29.0.4
  • Bookmarks app version: 14.2.3
  • Activated Nextcloud Apps: [the output of running $ sudo -u www-data php occ app:list in your command line]
  • Nextcloud configuration: [the output of running sudo -u www-data php occ config:list system]
  • Nextcloud external user backend: [e.g. ldap, or none]

Additional context
Add any other context about the problem here.

Web server error log

Insert your webserver log here

Nextcloud log (nextcloud/data/nextcloud.log)

Insert your Nextcloud log here

Browser log

Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log 
c) ...
Copy link

github-actions bot commented Aug 4, 2024

Hello 👋

Thank you for taking the time to open this issue with the bookmarks app. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and have been maintaining this software the last few years. I currently work for Nextcloud but maintain this app
in my free time, because it is not an official Nextcloud product. My day job at Nextcloud is pretty awesome but sadly leaves me with
less time for side projects like this one than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself. (Also see our Code of Conduct. Really.)

I look forward to working with you on this issue
Cheers 💙

@InfamousUser
Copy link
Author

Even worse now, the inner counter is at 7k, outer at 6.8k.

@marcelklehr
Copy link
Member

marcelklehr commented Aug 4, 2024

How many duplicates do you have? The overall bookmarks count only counts unique bookmarks, while the folder counts also count clones of the same bookmark in multiple folders.

@InfamousUser
Copy link
Author

InfamousUser commented Aug 4, 2024

Oh geez, there might be over 100, I have no clue, must be that. There is absolutely no way to know the counters show different things when they are in the same relative location and they're contents of folders that are one inside another. This should be clarified somehow or, rather, the counts equalized, this is highly unintuitive.

Maybe make them all show total and then add tooltip that says "Unique: x; Duplicates: Y"?

@marcelklehr
Copy link
Member

Yeah, I think you're right. It's more intuitive to subtract duplicates from the total than to add duplicates to the total to get the real total.

@marcelklehr
Copy link
Member

Thank you for the feedback! 💙

marcelklehr added a commit that referenced this issue Aug 7, 2024
used to be unique bookmarks including bookmarks in trashbin
now it's the same as normal folder counts: every item is counted

fixes #2202

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
(cherry picked from commit 1a22935)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants