Set Referrer-Policy header for nginx installation docs #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
approved these changes
Sep 10, 2018
|
@LouisMT the headers are set at two locations within the config file. You missed the second location. |
|
@tilosp is it? I'm only using it at one place on my config :) |
|
See: #855 |
|
Backport in #856 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Referrer-Policyheader to the example nginx configuration. Because a warning has been added since Nextcloud 14, I think this header should be included in the example config using the most strict value by default. In special use cases the user can adjust this value and use a less strict value if needed.See nextcloud/docker#451 and nextcloud/server#9122.
PS do I have to create another PR to target the
stable14branch?