Do not define loadBalancerIP on service unless set in values (#430)

* Update Chart.yaml Signed-off-by: Ben Yanke <ben@benyanke.com> * Update README.md Signed-off-by: Ben Yanke <ben@benyanke.com> * Update service.yaml Signed-off-by: Ben Yanke <ben@benyanke.com> * Update values.yaml Signed-off-by: Ben Yanke <ben@benyanke.com> * Bump version Signed-off-by: Ben Yanke <ben@benyanke.com> * Set to empty string instead of omitting value key Co-authored-by: JesseBot <jessebot@linux.com> Signed-off-by: Ben Yanke <ben@benyanke.com> * Update charts/nextcloud/README.md Co-authored-by: JesseBot <jessebot@linux.com> Signed-off-by: Ben Yanke <ben@benyanke.com> * Update charts/nextcloud/README.md - fix markdown chart formatting Signed-off-by: JesseBot <jessebot@linux.com> * Update charts/nextcloud/README.md - fix markdown formatting again Signed-off-by: JesseBot <jessebot@linux.com> --------- Signed-off-by: Ben Yanke <ben@benyanke.com> Signed-off-by: JesseBot <jessebot@linux.com> Co-authored-by: JesseBot <jessebot@linux.com>
nextcloud · Aug 23, 2023 · 3d31fa1 · 3d31fa1
1 parent 7ee7cf1
commit 3d31fa1
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/charts/nextcloud/Chart.yaml b/charts/nextcloud/Chart.yaml
@@ -1,6 +1,6 @@
 apiVersion: v2
 name: nextcloud
-version: 4.0.0
+version: 4.1.0
 appVersion: 27.0.2
 description: A file sharing server that puts the control and security of your own data back into your hands.
 keywords:

diff --git a/charts/nextcloud/README.md b/charts/nextcloud/README.md
@@ -156,7 +156,7 @@ The following table lists the configurable parameters of the nextcloud chart and
 | `cronjob.resources`                                        | CPU/Memory resource requests/limits for the cronjob sidecar                            | `{}`                       |
 | `cronjob.securityContext`                                  | Optional security context for cronjob                                                  | `nil`                      |
 | `service.type`                                             | Kubernetes Service type                                                                | `ClusterIP`                |
-| `service.loadBalancerIP`                                   | LoadBalancerIp for service type LoadBalancer                                           | `nil`                      |
+| `service.loadBalancerIP`                                   | LoadBalancerIp for service type LoadBalancer                                           | `""`                       |
 | `service.nodePort`                                         | NodePort for service type NodePort                                                     | `nil`                      |
 | `phpClientHttpsFix.enabled`                                | Sets OVERWRITEPROTOCOL for https ingress redirect                                      | `false`                    |
 | `phpClientHttpsFix.protocol`                               | Sets OVERWRITEPROTOCOL for https ingress redirect                                      | `https`                    |

diff --git a/charts/nextcloud/templates/service.yaml b/charts/nextcloud/templates/service.yaml
@@ -10,7 +10,7 @@ metadata:
     app.kubernetes.io/component: app
 spec:
   type: {{ .Values.service.type }}
-  {{- if eq .Values.service.type "LoadBalancer" }}
+  {{- if and (eq .Values.service.type "LoadBalancer") .Values.service.loadBalancerIP }}
   loadBalancerIP: {{ default "" .Values.service.loadBalancerIP }}
   {{- end }}
   ports:

diff --git a/charts/nextcloud/values.yaml b/charts/nextcloud/values.yaml
@@ -368,7 +368,7 @@ cronjob:
 service:
   type: ClusterIP
   port: 8080
-  loadBalancerIP: nil
+  loadBalancerIP: ""
   nodePort: nil
 
 ## Enable persistence using Persistent Volume Claims