Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp manageaccount #2951

Merged
merged 59 commits into from
Jun 21, 2024
Merged

Revamp manageaccount #2951

merged 59 commits into from
Jun 21, 2024

Conversation

marinofaggiana
Copy link
Member

@marinofaggiana marinofaggiana commented Jun 20, 2024 •
edited
Loading

  • Removed the account in the More view

Simulator Screenshot - iPhone 15 Pro Max - 2024-06-20 at 12 11 46

  • Added the Account Settings in the account menu left available on Files tab

Simulator Screenshot - iPhone 15 Pro Max - 2024-06-20 at 12 11 55

  • A new view

Simulator Screenshot - iPhone 15 Pro Max - 2024-06-20 at 12 12 04

@marinofaggiana
coding
13cc05f 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
cleaning
cde39ba 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
cleaning
9663729 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
fix
1114a24 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
f4fe392 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
91653e3 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
22b2b25 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
33a76b4 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
a793773 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
1eef14b 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
2b17a01 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
dbb6873 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
fix
cdceda4 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
0355022 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
23bf984 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
88e7bbb 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
ea451b9 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
321724a 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
c819d0f 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
2cf8803 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
704c0e6 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
3f26d60 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
297e334 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
c73b55c 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
a388609 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
304b6b8 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
030a3f8 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
fd7258f 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
37e117c 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
4ddbbc7 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
cod
202c190 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
39f8b76 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
d1cd4ae 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
cleaning
d010faf 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
24ddecf 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
fix icon
c911ea6 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
add timer for change user
a3f0bcb 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
cleaning
43a52bc 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
coding
8bbadec 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
Merge branch 'develop' into revamp-manageaccount
e0e2dfd 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@mpivchev
Copy link
Collaborator

Looks good!

image

  • Can you replace the email icon with one of these?

image

  • Can you remove the space between the Alias and the ":" ?

@mpivchev
Copy link
Collaborator

Simulator.Screen.Recording.-.iPhone.15.-.2024-06-20.at.13.23.24.mp4
  • If you swipe the carousel slowly it jumps around
  • There is an empty space cutoff on the edges
  • Can you add some animation when the height changes?

@mpivchev
Copy link
Collaborator

image

You can replace this icon with the gear icon for settings

@mpivchev
Copy link
Collaborator

mpivchev commented Jun 20, 2024 •
edited
Loading

image

It's hard to know you can swipe left and right on the accounts. Maybe scroll indicator dots can be good here

@marinofaggiana
Copy link
Member Author

image

It's hard to know you can swipe left and right on the accounts. Maybe scroll indicator dots can be good here

I have make some test and I don't like it (remember the swipe is not essential, in fact, it could easily be omitted)

@marinofaggiana
fix
db502b7 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
fix
7c8d7b8 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
Merge branch 'revamp-manageaccount' of https://github.com/nextcloud/ios…
ea6db02 
… into revamp-manageaccount

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

# Conflicts:
#	iOSClient/Supporting Files/it.lproj/Localizable.strings
@marinofaggiana
divide
fc0e838 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
move code
e3aac3d 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
add animation
b78fefa 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
+ animation
b557ef1 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
cleaning
bdf03eb 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
Advanced techniques
ad3ea5f 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
code cleaning
32af40c 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
cleaning
f9fa801 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana
new preview api
84a55b7 
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@marinofaggiana marinofaggiana merged commit d3b57b2 into develop Jun 21, 2024
4 checks passed
@marinofaggiana marinofaggiana deleted the revamp-manageaccount branch June 22, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpivchev mpivchev Awaiting requested review from mpivchev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marinofaggiana @mpivchev