Migrate to query builder mappers #1036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
changed the title
This was referenced Aug 16, 2018
|
…ry-builder-mapper
rullzer
previously requested changes
Aug 16, 2018
lib/Db/CollectedAddressMapper.php
Outdated
| ->from($this->getTableName()) | ||
| ->where( | ||
| $qb->expr()->eq('user_id', $qb->createNamedParameter($userId)), | ||
| $qb->expr()->orX( |
There was a problem hiding this comment.
Below you do andWhere on the sexond expression. Might make sense to do it consitently one way. (I prefer the andWhere since it makes it explicit it is an AND
There was a problem hiding this comment.
To be clear I mean
->where(
<1>,
<2>);
vs
->where(<1>)
->andWhere(<2>);
lib/Db/CollectedAddressMapper.php
Outdated
| ->select('*') | ||
| ->from($this->getTableName()) | ||
| ->where($qb->expr()->eq('user_id', $qb->createNamedParameter($userId))) | ||
| ->andWhere($qb->expr()->eq('email', $qb->createNamedParameter($email))); |
There was a problem hiding this comment.
The original expersssion does an ILIKE.. this is pure equal. intentional?
There was a problem hiding this comment.
Not intentional, but rather a copy-paste error :P
lib/Db/LocalAttachmentMapper.php
Outdated
| $query = $qb | ||
| ->select('*') | ||
| ->from($this->getTableName()) | ||
| ->where($qb->expr()->eq('user_id', $qb->createNamedParameter($userId))); |
There was a problem hiding this comment.
The oroginal statement has id = ? this one not. Intentional?
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
rullzer
approved these changes
Aug 17, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and questions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #960.
Required for #959.
This migration is mandatory as the old mappers are deprecated now.