-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
occ app update command #11053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
occ app update command #11053
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,125 @@ | ||
<?php | ||
/** | ||
* @copyright Copyright (c) 2018, michag86 (michag86@arcor.de) | ||
* | ||
* @license GNU AGPL version 3 or any later version | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU Affero General Public License as | ||
* published by the Free Software Foundation, either version 3 of the | ||
* License, or (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU Affero General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU Affero General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
* | ||
*/ | ||
|
||
namespace OC\Core\Command\App; | ||
|
||
use OCP\App\IAppManager; | ||
use OC\Installer; | ||
use OCP\ILogger; | ||
use Symfony\Component\Console\Command\Command; | ||
use Symfony\Component\Console\Input\InputArgument; | ||
use Symfony\Component\Console\Input\InputOption; | ||
use Symfony\Component\Console\Input\InputInterface; | ||
use Symfony\Component\Console\Output\OutputInterface; | ||
|
||
class Update extends Command { | ||
|
||
/** @var IAppManager */ | ||
protected $manager; | ||
/** @var Installer */ | ||
private $installer; | ||
/** @var ILogger */ | ||
private $logger; | ||
|
||
/** | ||
* @param IAppManager $manager | ||
* @param Installer $installer | ||
*/ | ||
public function __construct(IAppManager $manager, Installer $installer, ILogger $logger) { | ||
parent::__construct(); | ||
$this->manager = $manager; | ||
$this->installer = $installer; | ||
$this->logger = $logger; | ||
} | ||
|
||
protected function configure() { | ||
$this | ||
->setName('app:update') | ||
->setDescription('update an app or all apps') | ||
->addArgument( | ||
'app-id', | ||
InputArgument::OPTIONAL, | ||
'update the specified app' | ||
) | ||
->addOption( | ||
'all', | ||
null, | ||
InputOption::VALUE_NONE, | ||
'update all updatable apps' | ||
) | ||
->addOption( | ||
'showonly', | ||
null, | ||
InputOption::VALUE_NONE, | ||
'show update(s) without updating' | ||
) | ||
|
||
; | ||
} | ||
|
||
protected function execute(InputInterface $input, OutputInterface $output) { | ||
$singleAppId = $input->getArgument('app-id'); | ||
|
||
if ($singleAppId) { | ||
$apps = array($singleAppId); | ||
try { | ||
$this->manager->getAppPath($singleAppId); | ||
} catch (\OCP\App\AppPathNotFoundException $e) { | ||
$output->writeln($singleAppId . ' not installed'); | ||
return 1; | ||
} | ||
|
||
} else if ($input->getOption('all') || $input->getOption('showonly')) { | ||
$apps = \OC_App::getAllApps(); | ||
} else { | ||
$output->writeln("<error>Please specify an app to update or \"--all\" to update all updatable apps\"</error>"); | ||
michag86 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return 1; | ||
} | ||
|
||
$return = 0; | ||
foreach ($apps as $appId) { | ||
$newVersion = $this->installer->isUpdateAvailable($appId); | ||
if ($newVersion) { | ||
$output->writeln($appId . ' new version available: ' . $newVersion); | ||
|
||
if (!$input->getOption('showonly')) { | ||
try { | ||
$result = $this->installer->updateAppstoreApp($appId); | ||
} catch(\Exception $e) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be good to log also the exception here. Let me do that. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wouldn't it make sense to also use |
||
$this->logger->logException($e, ['message' => 'Failure during update of app "' . $appId . '"','app' => 'app:update']); | ||
$output->writeln('Error: ' . $e->getMessage()); | ||
$return = 1; | ||
} | ||
|
||
if ($result === false) { | ||
$output->writeln($appId . ' couldn\'t be updated'); | ||
$return = 1; | ||
} else if($result === true) { | ||
$output->writeln($appId . ' updated'); | ||
} | ||
} | ||
} | ||
} | ||
|
||
return $return; | ||
} | ||
} | ||
|
Uh oh!
There was an error while loading. Please reload this page.