ACCEPT_LANGUAGE goes before default_langauge #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #970 Before we had 1. Users settings in personal settings 2. Admins default language settings 3. Accept-Language settings of the browser However this is not in line with https://www.w3.org/International/questions/qa-lang-priorities So this changes the order to 1. Users settings in personal settings 3. Accept-Language settings of the browser 2. Admins default language settings
|
@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @nickvergessen, @LukasReschke and @MorrisJobke to be potential reviewers |
|
Tested and works 👍 |
|
👍 |
|
@rullzer original issue was filled against 10.0.1 ... should this be backported? cc @karlitschek |
|
I don't really think so. |
|
please backport 👍 |
|
@rullzer Why not? |
|
It's somewhat a behaviour change. Not sure if we should backport this either. On the other hand for registered users it doesn't change anything. So maybe we could backport a "simpler" version of the patch |
|
Exactly it changes behaviour. Ok fair enough it changes it to the correct one. But it is not a bug that leads to dataloss etc. Backporting always brings a risk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #970
Before we had
However this is not in line with
https://www.w3.org/International/questions/qa-lang-priorities
So this changes the order to
@kohtala @MorrisJobke please have a look