Allow to disable system addressbook sync

[tcitworld]

On some instances, users don't know each other and it doesn't makes
sense to expose users as contacts (through Contacts Menu, Calendar
Attendees,…) to everyone.

A parameter inside settings/admin/groupware allows to enable/disable the syncing of this system addressbook.

If this feature is disabled, the occ dav:sync-system-addressbook command empties the system addressbook (it's automatically refilled if the feature is activated again and synced).

• Fix and add tests

[skjnldsv]

single quotes ;)

[tcitworld]

You know I'm always just copy pasting. ;) https://github.com/nextcloud/server/blob/master/apps/dav/js/settings-admin-caldav.js#L22

[georgehrke]

@schiessle Will this have any effect on federation?

[georgehrke]

Can we have purgeSystemAddressBook and the SyncSystemAddressBook command covered by a unit test please? :)

Code-changes look good besides what @skjnldsv noted.

[jancborchardt]

@tcitworld can you post a quick screenshot for review? :)

[georgehrke]

Tests added

[tcitworld]

Tests added.

I'm waiting to see if #13796 or this one is merged first to adapt the settings section.

[georgehrke]

#13796 was merged.

Can you please add "Also install the Contacts app, or connect your desktop & mobile for syncing ↗" similar to #13796 :)

[tcitworld]

Just done it ! :)

[MorrisJobke]

@schiessle Will this have any effect on federation?

Yes - this is basically how users are exchanged between trusted servers. If this is disabled then the users are not exchanged anymore.

[tcitworld]

@MorrisJobke Do you want an extra warning then ?

[tcitworld]

@MorrisJobke @georgehrke We now empty the addressbook instead of removing it, so that it doesn't break Federated Cloud Sharing.

[MorrisJobke]

@MorrisJobke @georgehrke We now empty the addressbook instead of removing it, so that it doesn't break Federated Cloud Sharing.

Still it empties the basic concept of what trusted servers rely on. I would like to have @schiessle's opinion here.

[tcitworld]

@schiessle Can you have a look ⬆️

[tcitworld]

Rebased.

[schiessle]

I'm know I'm late to this PR, sorry about that.

occ dav:sync-system-addressbook is used to sync users across servers. It syncs with all trusted servers. A trusted server relationship between two servers is created if both admins knowledge the other server as trusted, aka adding it to this list in the system settings (admin settings -> sharing):

If you don't want to sync user lists accross server you can simply disable the "Federation"-app.

But if I understand the initial post correctly:

On some instances, users don't know each other and it doesn't makes
sense to expose users as contacts (through Contacts Menu, Calendar
Attendees,…) to everyone.

The main concern are internal users exposed to each other. So it seems like some occ commands and features are mixed up here.

If you have a huge instance where not everyone should see everyone you could use the sharing admin setting "Restrict users to only share with users in their groups" to auto-complete only users in the same group. This way you can divide the users by groups.

If the user should be able to share with everyone as long as they know the complete uid but disable auto-completion and suggestions you can set

'sharing.maxAutocompleteResults' => 0,
in the config.php

Anyway, I would not provide a setting to kill the local address book completely because it might be used for many different things. Therefore I also don't know if "groupware" is the right category.

Sorry for the lengthy response and sorry if I misunderstand something.

[tcitworld]

Thank you for answering.

Sorry for not being clear enough, the issue was not really about the (Federated) Sharees API, but more about the OC\ContactsManager.

The original aim of this PR was to make only the user's addressbooks contacts available through ContactsMenu and calendar attendees.

I digged the code up and ended up here, but maybe it would be better to hook into OC\ContactsManager instead, by filtering with $addressBook->getUri(), so that the system addressbook is still available for other uses.

EDIT: But it seems OC\ContactsManager is called at a bunch of other places too, so that won't do it. 😞

[tcitworld]

Closed until something good come out.