-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move calendar settings into basic settings #13796
Conversation
👎 #13765 Is gonna add more settings to group ware |
On top of that, apps that implement custom Room / Resource backends for calendar scheduling are also supposed to put their UI into the groupware category :) |
Circles was also in there iirc. |
@georgehrke @juliushaertl alright, good stuff then! :) Will remove the moving of the Calendar server from my pull request. Still modifying some more stuff. :) |
Alright, moved it back, but now I need some help – @georgehrke?
|
👍 |
It's the correct link, but the documentation is just missing. @MariusBluem What's the status on the calendar doc? |
afc0122
to
29f33ba
Compare
@jancborchardt Done |
Awesome, thanks a lot @georgehrke! Please review @nextcloud/calendar @nextcloud/designers 🚀 |
<em> | ||
<?php print_unescaped(str_replace( | ||
[ | ||
'{emailopen}', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@georgehrke guess this is supposed to be called "linkopen"? Not sure :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I basically copied it from here: https://github.com/nextcloud/server/blob/master/settings/templates/settings/personal/development.notice.php#L16
{emailopen} will only be visible to the translators anyway.
<p> | ||
<input type="checkbox" name="caldav_send_invitations" id="caldavSendInvitations" class="checkbox" | ||
<?php ($_['send_invitations'] === 'yes') ? print_unescaped('checked="checked"') : null ?>/> | ||
<label for="caldavSendInvitations"><?php p($l->t('Send invitations to attendees')); ?></label> | ||
<br> | ||
<em><?php p($l->t('Please make sure to properly set up the email settings above.')); ?></em> | ||
<em> | ||
<?php print_unescaped(str_replace( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use p
and use the l10n sprintf method:
p($l->t('%s of %s used', [$_['usage'], $_['total_space']]));
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p()
will escape <a href="../admin#mail_general_settings">
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes, then just the translation ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but p will print the text and once it's printed i can't replace {emailopen}
or {linkclose}
😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
print_unescaped($l->t(
'Please make sure to properly set up %sthe email server↗%s.',
'<a href="../admin#mail_general_settings">',
'</a>'
));
And I can see %sthe
causing issues.
I don't know, the str_replace seemed weird to me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I throw <?php p($l->t('Please make sure to properly set up')) ?> <a href="../admin#mail_general_settings"><?php p($l->t('the email server ↗')) ?></a>
in the ring 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, the str_replace seemed weird to me 😀
As i said above already, I just copied it from https://github.com/nextcloud/server/blob/master/settings/templates/settings/personal/development.notice.php#L16
😉
'<a href="../admin#mail_general_settings">', | ||
'</a>', | ||
], | ||
$l->t('Please make sure to properly set up {emailopen}the email server↗{linkclose}.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is usually one whitespace before ↗.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually that should not be here at all since it’s only used for external links. :)
If we have a verdict on the syntax of the link / translation combination, then it can be fixed in one go.
@@ -30,12 +30,26 @@ | |||
?> | |||
<form id="CalDAV" class="section"> | |||
<h2><?php p($l->t('Calendar server')); ?></h2> | |||
<p class="settings-hint">Also install the <a target="_blank" href="../apps/office/calendar">Calendar app</a>, or | |||
<a target="_blank" href="<?php p(link_to_docs('user-sync-calendars')) ?>" rel="noreferrer noopener">connect your desktop & mobile for syncing</a>.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't these be translated as well ?
@georgehrke Same as I‘ve done with the CalDAV/CarDAV sync docs, I will create a PR with the Basic stuff which can be improved later ... End of this week :) |
I made the text @jancborchardt added translatable, added a ↗ to the link to the docs and removed the ↗ from the link to the mail settings. |
@jancborchardt @skjnldsv @MariusBluem Please check again :) |
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
6fb97a7
to
ea1f6f6
Compare
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
On some instances, users don't know each other and it doesn't makes sense to expose users as contacts (through Contacts Menu, Calendar Attendees,…) to everyone. Signed-off-by: Thomas Citharel <tcit@tcit.fr> Fix and add tests Signed-off-by: Thomas Citharel <tcit@tcit.fr> Change settings template according to #13796 Signed-off-by: Thomas Citharel <tcit@tcit.fr> Empty system addressbook instead of removing it This makes Federated Cloud Sharing not fail when synching trusted servers addressbooks (only synching an empty one, not bumping on an non-existent one). Signed-off-by: Thomas Citharel <tcit@tcit.fr> Fix tests Signed-off-by: Thomas Citharel <tcit@tcit.fr>
On some instances, users don't know each other and it doesn't makes sense to expose users as contacts (through Contacts Menu, Calendar Attendees,…) to everyone. Signed-off-by: Thomas Citharel <tcit@tcit.fr> Fix and add tests Signed-off-by: Thomas Citharel <tcit@tcit.fr> Change settings template according to #13796 Signed-off-by: Thomas Citharel <tcit@tcit.fr> Empty system addressbook instead of removing it This makes Federated Cloud Sharing not fail when synching trusted servers addressbooks (only synching an empty one, not bumping on an non-existent one). Signed-off-by: Thomas Citharel <tcit@tcit.fr> Fix tests Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Currently the "Groupware" settings section only has Calendar settings. This doesn’t make a lot of sense. And the sentence below the checkbox says it all:
Fixed by moving it to basic settings, and improved the spacing (Also fixes background jobs):
Please review @nextcloud/designers @karlitschek