Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump strenghify to v0.5.8 #14833

Merged

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Mar 25, 2019

To include nextcloud/strengthify#28.

Fixes the zxcvbn is undefined error on the setup page
Fixes Database password visibility toggle not toggleable via space (works for admin password) from #14639 (tested & works)

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@MorrisJobke
Copy link
Member

dependachristoph/npm_and_yarn/strengthify-v0.5.8

🤣

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@faily-bot
Copy link

faily-bot bot commented Mar 25, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17283: failure

TESTS=acceptance, TESTS-ACCEPTANCE=app-files-sharing-link

  • tests/acceptance/features/app-files-sharing-link.feature:3
Show full log
  Scenario: open the menu in a public shared link                   # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:3
    Given I act as John                                             # ActorContext::iActAs()
    And I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt"                          # FilesAppSharingContext::iShareTheLinkFor()
      Share link row in the details view in Files app could not be found after 50 seconds
      Add new share link button in the details view in Files app could not be found after 50 seconds (NoSuchElementException)
    And I write down the shared link                                # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                              # ActorContext::iActAs()
    And I visit the shared link I wrote down                        # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I open the Share menu                                       # PublicShareContext::iOpenTheShareMenu()
    Then I see that the Share menu is shown                         # PublicShareContext::iSeeThatTheShareMenuIsShown()
sh: 1: kill: No such process

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 25, 2019
@MorrisJobke MorrisJobke merged commit 736fbe7 into master Mar 25, 2019
@MorrisJobke MorrisJobke deleted the dependachristoph/npm_and_yarn/strengthify-v0.5.8 branch March 25, 2019 13:37
@rullzer rullzer mentioned this pull request Mar 26, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants