Skip to content

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Mar 29, 2017

Signed-off-by: Arthur Schiwon blizzz@arthur-schiwon.de

Downstream of owncloud/user_ldap#9

This is adjusted in this command instead of the user/group backend, because IUserBackend and IGroupBackend accept the limit parameters differently.

Please review @nextcloud/ldap

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@mention-bot
Copy link

@blizzz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @LukasReschke and @MorrisJobke to be potential reviewers.

@codecov-io
Copy link

Codecov Report

Merging #4141 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #4141      +/-   ##
============================================
- Coverage     54.18%   54.18%   -0.01%     
- Complexity    21316    21317       +1     
============================================
  Files          1309     1309              
  Lines         81343    81345       +2     
  Branches       1285     1285              
============================================
- Hits          44079    44078       -1     
- Misses        37264    37267       +3
Impacted Files Coverage Δ Complexity Δ
apps/user_ldap/lib/Command/Search.php 0% <0%> (ø) 14 <0> (+1) ⬆️
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 626d03e...9e2e0c4. Read the comment docs.

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes total sense 👍

@MorrisJobke MorrisJobke merged commit d17678b into master Mar 29, 2017
@MorrisJobke MorrisJobke deleted the ldap-downstream-9 branch March 29, 2017 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants