user_ldap: Add support for gidNumber #4489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is based on the work of @dleeuw (https://github.com/dleeuw) (See #2640 (comment) for more details). The difference is user & group data will be written into cache to have better performance, and functions splited from primaryGroupID series to make them more readable. Fixed #2640 Signed-off-by: Xuanwo <xuanwo@yunify.com>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
requested review from
rullzer,
nickvergessen,
MorrisJobke and
GitHubUser4234
|
👍 (since i cannot github-review self-opened PRs even if the code but one line isn't mine) |
|
OK, It's the same for me, hoping for the merge. 😄 |
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Codecov Report
@@ Coverage Diff @@
## master #4489 +/- ##
============================================
- Coverage 53.96% 28.67% -25.3%
- Complexity 21679 21725 +46
============================================
Files 1272 1272
Lines 75789 75280 -509
============================================
- Hits 40898 21583 -19315
- Misses 34891 53697 +18806
|
|
One test failed, I pushed a fix. Signoff fails for the merge commit → ignore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3218 by @Xuanwo with one adjustement due to changed method name.
Works for me.
Another reviewer? @nextcloud/ldap