Skip to content

refactor: prepare Vue 3 migration #55432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

refactor: prepare Vue 3 migration #55432

wants to merge 3 commits into from
+44,288 −23,521

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Sep 30, 2025 •
edited
Loading

Summary

  1. move legacy building to build/frontend-legacy (vue 2 apps)
  • apps are symlinked to be builded with webpack as before
  1. build script in root is now for Vue 3 apps
  2. migrated sharebymail as an example app.

Checklist

@susnux susnux added 2. developing Work in progress technical debt ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Sep 30, 2025
@nextcloud nextcloud deleted a comment Sep 30, 2025
@nextcloud nextcloud deleted a comment Sep 30, 2025
come-nc
come-nc reviewed Sep 30, 2025
View reviewed changes
come-nc
come-nc reviewed Sep 30, 2025
View reviewed changes
@susnux susnux requested a review from come-nc October 1, 2025 11:51
@susnux susnux marked this pull request as ready for review October 1, 2025 11:51
@susnux susnux requested review from a team as code owners October 1, 2025 11:51
@susnux susnux requested review from nfebe, skjnldsv, szaimen, ArtificialOwl, artonge and CarlSchwan and removed request for a team and ArtificialOwl October 1, 2025 11:51
@susnux susnux added this to the Nextcloud 33 milestone Oct 1, 2025
@susnux susnux force-pushed the feat/vue3-demi-2 branch 2 times, most recently from d33fadc to 384e5a4 Compare October 1, 2025 12:07
szaimen
szaimen approved these changes Oct 1, 2025
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

artonge
artonge reviewed Oct 1, 2025
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build files from both systems are ending up in the dist directory? Could there be some conflicts?

package.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we keep most of the commands here to be able to run them from the root folder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes its planned :)

@susnux susnux mentioned this pull request Oct 2, 2025
Open
22 tasks
@susnux susnux force-pushed the feat/vue3-demi-2 branch 3 times, most recently from f84a492 to d19fe63 Compare October 2, 2025 19:57
susnux added 3 commits October 3, 2025 18:15
@susnux
chore: prepare Vue 3 migration by moving legacy building
2280922 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
refactor(sharebymail): migrate app to Vue 3
1bac94d 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore(Template): allow styles from dist folder
1290c76 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge left review comments

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@szaimen szaimen szaimen approved these changes

@come-nc come-nc Awaiting requested review from come-nc

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-frontend

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner automatically assigned from nextcloud/server-frontend

+1 more reviewer

@kmk142789 kmk142789 kmk142789 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
2. developing Work in progress ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt
Projects
None yet
Milestone
Nextcloud 33
Development

Successfully merging this pull request may close these issues.
6 participants
@susnux @artonge @CarlSchwan @szaimen @come-nc @kmk142789