-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix initializing paged search under some circumstances #6453
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Existing and new LDAP config works 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to still work on my ldap test instance :)
Let me rebase to get the latest fixes on master. |
5ea966b
to
ab65784
Compare
Rebased |
Codecov Report
@@ Coverage Diff @@
## master #6453 +/- ##
===========================================
- Coverage 55.53% 53.4% -2.14%
- Complexity 21243 22521 +1278
===========================================
Files 1253 1407 +154
Lines 73203 87100 +13897
Branches 0 1329 +1329
===========================================
+ Hits 40653 46513 +5860
- Misses 32550 40587 +8037
|
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
ab65784
to
0b62506
Compare
Waiting for CI: https://drone.nextcloud.com/nextcloud/server/1537 |
error during connect: Post http://%2Fvar%2Frun%2Fdocker.sock/v1.26/networks/create: EOF 😭 |
@blizzz Ignore that single occurrence for now |
Fixes #5273 and #6388
Basically the issue was, that a paged search might not be properly initialized, when no limit was given, but a previous search had a limit set. This resulted in strange behaviour as described in #5273. While debugging this, I figured out, @eigood recently also saw the wrong spot in the code as described in #6388.
Added Paged Search Integration tests cover the case.
Please test and review @nextcloud/ldap @zfzfzf33 @eigood @bline
Backport is necessary.