Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't provide props via navigating #2218

Merged
merged 1 commit into from Mar 7, 2023
Merged

Conversation

raimund-schluessler
Copy link
Member

Passing params that are not defined on the path will break with vue-router 4.1.4, since it's an anti-pattern. See https://github.com/vuejs/router/blob/main/packages/router/CHANGELOG.md#important-note.

So we don't do this anymore and instead open the tab via an emitted event after the AppSidebar was mounted.

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #2218 (87ebed6) into master (f84b0ac) will decrease coverage by 1.52%.
The diff coverage is 25.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2218      +/-   ##
============================================
- Coverage     28.65%   27.13%   -1.52%     
============================================
  Files            69       60       -9     
  Lines          3033     2915     -118     
  Branches        733      738       +5     
============================================
- Hits            869      791      -78     
+ Misses         2164     2124      -40     

@raimund-schluessler raimund-schluessler merged commit 0b9ebf8 into master Mar 7, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/noid/open-notes branch March 7, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant