-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(vite): Migrate from webpack to vite #2321
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2321 +/- ##
==========================================
+ Coverage 24.79% 24.83% +0.04%
==========================================
Files 63 63
Lines 2396 2392 -4
Branches 258 257 -1
==========================================
Hits 594 594
+ Misses 1785 1780 -5
- Partials 17 18 +1 |
Not sure what you mean, I do not think there is anything to adjust in the config package. ESM projects can always import CJS, but CJS can not require ESM packages (only dynamically import them). |
What do you mean by blocked? Module JS (aka mjs aka ESM) is only supported with Nextcloud 27 and newer (there was a bug in 27.0.0 so 27.0.1 or newer). If you have 27.0.1+ it should work as expected, as then Nextcloud will add As an example you could look as the logreader app which is already using that feature. |
My dev environment is server latest master, but it could be that the webserver is not configured correctly, I guess. I get this error message when
I didn't try with my production environment yet, though. |
Exactly this error means the webserver does not send the correct mime type for mjs files. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
622bf32
to
d91852d
Compare
f8b579f
to
3d89ef5
Compare
With |
3d89ef5
to
8429627
Compare
8429627
to
23783e7
Compare
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
23783e7
to
f812a6a
Compare
This migrates the build from
webpack
tovite
. This saves a bit on bundle size, but we have to include every stylesheet manually.