Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove old link when editing #5690

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

remove old link when editing #5690

wants to merge 7 commits into from

Conversation

grnd-alt
Copy link
Member

@grnd-alt grnd-alt commented Apr 15, 2024 •
edited by max-nextcloud
Loading

Fixes #5516

@grnd-alt
remove old link when editing
48f2347 
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
@grnd-alt grnd-alt linked an issue Apr 15, 2024 that may be closed by this pull request
Updating the URL of a link via toolbar menu splits the link #5516
Open
@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Apr 16, 2024
@juliusknorr juliusknorr added this to the Nextcloud 30 milestone Apr 16, 2024
@max-nextcloud
Copy link
Collaborator

The current change works well when only changing a single link in a paragraph.
There are two more scenarios that would be good to account for:

Link in a paragraph

Find more information on https://nextcloud.com as usual.

-> should only change the link.

Link with custom text

More informarion

-> should only change the href.

@max-nextcloud max-nextcloud self-assigned this Apr 17, 2024
@max-nextcloud max-nextcloud force-pushed the fix/5516-updating-the-url-of-a-link-via-toolbar-menu-splits-the-link branch from 2d91369 to 95cc248 Compare April 17, 2024 13:48
@max-nextcloud
refactor(links): add insertOrSetLink command
177e3e0 
Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud
refactor(cy): move Links.spec.js into e2e folder
16c2511 
It is a proper e2e test driving the ui.

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud
test(cy): initial test for the link mark
35f1d07
@max-nextcloud max-nextcloud force-pushed the fix/5516-updating-the-url-of-a-link-via-toolbar-menu-splits-the-link branch from 10bfdeb to 35f1d07 Compare April 17, 2024 14:17
@max-nextcloud
test(cy): adjust import path in moved Links.spec.js
d705663 
Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud
refactor(link): use isMarkActive in insertOrSetLink
2a26029 
This way we do not hand in the active state
and avoid inconsistencies.

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud
test(cy): add some failing tests for insertOrSetLink
f9e4df3 
Signed-off-by: Max <max@nextcloud.com>
This was referenced Jul 30, 2024
Merged
Merged
This was referenced Aug 5, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 22, 2024
Merged
44 tasks
This was referenced Aug 29, 2024
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 30, Nextcloud 31 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud max-nextcloud is a code owner

@elzody elzody Awaiting requested review from elzody

At least 1 approving review is required to merge this pull request.

Assignees

@max-nextcloud max-nextcloud

Labels
3. to review bug Something isn't working
Projects
📝 Office team
Status: 👀 In review
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.

Updating the URL of a link via toolbar menu splits the link
4 participants
@grnd-alt @max-nextcloud @blizzz @juliusknorr