Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(ci): cypress workflow to use latest dependencies with node 20 #5693

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

max-nextcloud
Copy link
Collaborator

📝 Summary

  • Resolves: Warnings during cypress runs such as

grafik

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation is not required

@max-nextcloud max-nextcloud force-pushed the update/cypress-workflow-dependencies branch 9 times, most recently from 2e1940a to 6cb7e6d Compare April 17, 2024 08:11
@max-nextcloud max-nextcloud force-pushed the update/cypress-workflow-dependencies branch from 6cb7e6d to 6080c80 Compare April 17, 2024 08:27
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should have dependabot/renovate configured to bump the versions for github actions that we don't pull from the templates?

@max-nextcloud
Copy link
Collaborator Author

Maybe we should have dependabot/renovate configured to bump the versions for github actions that we don't pull from the templates?

If we can limit it to those - would be nice.

@max-nextcloud
Copy link
Collaborator Author

For time comparison

before after
grafik grafik

Some faster, some slower - i guess flaky tests have a bigger effect here than the change.

But all in all looks like we could use it.

@max-nextcloud max-nextcloud marked this pull request as ready for review April 17, 2024 12:36
@max-nextcloud
Copy link
Collaborator Author

If we can limit it to those - would be nice.

I did not find an easy way. Updating versions in workflows shared via the org would only create additional conflicts i think.

Easiest way that came to my mind was moving the action to a separate workflow repo that then uses dependabot for the updates.

@juliusknorr juliusknorr merged commit a162f5a into main Apr 23, 2024
63 checks passed
@juliusknorr juliusknorr deleted the update/cypress-workflow-dependencies branch April 23, 2024 17:31
@juliusknorr
Copy link
Member

Easiest way that came to my mind was moving the action to a separate workflow repo that then uses dependabot for the updates.

Maybe we can also use renovate or dependabot just for this workflow in text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants