Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] Fix: use composables in setup function #6020

Closed
wants to merge 2 commits into from

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jul 9, 2024

Backport of #6017

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added this to the Nextcloud 28.0.8 milestone Jul 9, 2024
@solracsf solracsf changed the title [stable28] [stable29] Fix: use composables in setup function [stable28] Fix: use composables in setup function Jul 17, 2024
Signed-off-by: Max <max@nextcloud.com>
* Use `useElementSize` instead of `useResizeObserver`.

* These composables are meant to be used in composition API style.

Signed-off-by: Max <max@nextcloud.com>
@mejo- mejo- marked this pull request as ready for review July 23, 2024 10:41
@mejo-
Copy link
Member

mejo- commented Jul 23, 2024

@max-nextcloud and me decided it's not worth the effort do debug what is missing as the functionality is there already on stable28 and it doesn't really fix anything user-visible.

@mejo- mejo- closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants