Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to rullzer/easytotp #489

Merged
merged 2 commits into from
Mar 11, 2019
Merged

Move to rullzer/easytotp #489

merged 2 commits into from
Mar 11, 2019

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Mar 4, 2019 •
edited
Loading

Fixes #479

  • Move to rullzer/easytotp
  • Save timecounter in DB
  • pass timecounter to lib

Future work:

  • Seems that we also use the old lib to generate a valid secret. We could just do this ourselfs I guess.

@ChristophWurst ChristophWurst added this to the next milestone Mar 7, 2019
ChristophWurst
ChristophWurst reviewed Mar 8, 2019
View reviewed changes
appinfo/info.xml Outdated Show resolved Hide resolved
ChristophWurst
ChristophWurst approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and all the tests passed. Awesome!

In the future we should also add unit and integration tests for the code reuse, just t be sure it does not break unnoticed.

@rullzer
Move to rullzer/easytotp
a657501 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
Move to 7.1 test since this will be 7.1 now
5815c6e 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
ChristophWurst
ChristophWurst approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could log in with a registration from the old lib 👍

@ChristophWurst ChristophWurst merged commit b5fbbde into master Mar 11, 2019
@ChristophWurst ChristophWurst deleted the enh/479 branch March 11, 2019 14:32
@rullzer rullzer mentioned this pull request Mar 15, 2019
Closed
@ChristophWurst ChristophWurst mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

Assignees
No one assigned
Labels
4. to release dependencies enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rullzer @ChristophWurst