-
Notifications
You must be signed in to change notification settings - Fork 26
Conversation
… request" This reverts commit 6e20eb5.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Nice! Greetings |
Works with all my keys on both FF and Chromium. Chromium apparently doesn't activate the u2f device instantly (the LED isn't blinking right away), it takes a few seconds until it's active. |
cc @go2sh |
You can use this zip for testing: |
Ok! Seems ok.
I registered two PlugUp-Keys in Two Accounts (4 registrations) [Windows 10 64-bit]
I did not see anything bad..! |
- 5.3 | ||
- 5.4 | ||
- 5.5 | ||
- 5.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5.6 is included via the matrix ;-)
It was basically run redundantly, so I removed one build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the PHP changes look good or have been tested before.
[I cannot tell anything about structural things, but they do not look bad from my point of view. (Changes which are not PHP).]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and works on Chromium and Firefox for me.
Thanks everyone for helping with this critical issue! I've packaged a nighly build https://github.com/nextcloud/twofactor_u2f/releases/tag/nightly-20170509 |
Supersedes #48
Fixes #45