NMC/2341 - NCTrashView #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSI-shwetawaikar
changed the title
| @@ -84,7 +84,7 @@ extension NCTrash: UICollectionViewDataSource { | |||
| cell = listCell | |||
| } else { | |||
| // GRID | |||
| guard let gridCell = collectionView.dequeueReusableCell(withReuseIdentifier: "gridCell", for: indexPath) as? NCGridCell else { return UICollectionViewCell() } | |||
| guard let gridCell = collectionView.dequeueReusableCell(withReuseIdentifier: "gridCell", for: indexPath) as? NCTrashGridCell else { return UICollectionViewCell() } | |||
There was a problem hiding this comment.
Suggestion: Wherever existing code is customized. Put a comment above mentioning "MagentaCloud Customization" to identify our customization during code conflict. It will also help new developers.
TSI-amrutwaghmare
force-pushed
the
nmc/2341-Trash-view
branch
2 times, most recently
from
2e1dab3
to
8f09012
Compare
TSI-amrutwaghmare
force-pushed
the
nmc/2341-Trash-view
branch
from
ab842df
to
372c941
Compare
TSI-amrutwaghmare
force-pushed
the
nmc/2341-Trash-view
branch
from
76d5c9d
to
563521a
Compare
TSI-amrutwaghmare
force-pushed
the
nmc/2341-Trash-view
branch
from
cf926aa
to
d0d8d29
Compare
TSI-amrutwaghmare
force-pushed
the
nmc/2341-Trash-view
branch
from
10583aa
to
9d0e7b0
Compare
TSI-amrutwaghmare
force-pushed
the
nmc/2341-Trash-view
branch
from
aa60ea4
to
a3f7492
Compare
TSI-amrutwaghmare
force-pushed
the
nmc/2341-Trash-view
branch
2 times, most recently
from
aed7af8
to
8336512
Compare
TSI-amrutwaghmare
force-pushed
the
nmc/2341-Trash-view
branch
from
78d90c5
to
b49fa7f
Compare
TSI-amrutwaghmare
force-pushed
the
nmc/2341-Trash-view
branch
from
27fc96c
to
2292999
Compare
TSI-amrutwaghmare
force-pushed
the
nmc/2341-Trash-view
branch
from
2292999
to
858f534
Compare
TSI-amrutwaghmare
force-pushed
the
nmc/2341-Trash-view
branch
from
858f534
to
8b07af6
Compare
TSI-amrutwaghmare
force-pushed
the
nmc/2341-Trash-view
branch
from
8b07af6
to
20d808f
Compare
harshada-15-tsys
force-pushed
the
nmc/2341-Trash-view
branch
from
20d808f
to
a3360b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
We have added some changes related to Grid View selection in "Deleted files" section in More Tab.