augur curate format-dates: mask empty fields #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1509 +/- ##
==========================================
+ Coverage 69.53% 69.57% +0.03%
==========================================
Files 73 73
Lines 7789 7792 +3
Branches 1905 1906 +1
==========================================
+ Hits 5416 5421 +5
+ Misses 2087 2086 -1
+ Partials 286 285 -1 ☔ View full report in Codecov by Sentry. |
genehack
approved these changes
Jul 1, 2024
joverlee521
force-pushed
the
format-dates-accept-mask
branch
from
2cd7111
to
25f4993
Compare
Shows current behavior when the date field is empty or whitespace only.
If a date field is empty, it should be completely masked to indicate that the date is unknown. Resolves <#1507>
The user should be providing date fields that exist in the record. Raise a loud error if a field does not exist!
joverlee521
force-pushed
the
format-dates-mask-empty
branch
from
d55130f
to
c2f29cf
Compare
|
Rebased on to master to resolve merge conflicts in changelog and updated changelog. |
victorlin
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Mask empty date fields as
XXXX-XX-XXto represent unknown dates.Also includes a change to raise a loud error if user requests a date field that does not exist in the record.
Related issue(s)
Resolves #1507
Checklist