Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schemas to allow display defaults for transmission lines #561

Merged
merged 1 commit into from Jun 8, 2020

Conversation

jameshadfield
Copy link
Member

Schemas and test builds updated to allow one to define a display default
in a dataset JSON to toggle on/off the transmission lines (if available).
See the corresponding auspice PR nextstrain/auspice#1152.

Additionally, the logic for setting display_defaults within augur export v2 is
improved so that we no longer have to define the valid keys in the source code.
Invalid keys are still identified via validating the JSONs against schemas.

Schemas and test builds updated to allow one to define a display default
in a dataset JSON to toggle on/off the transmission lines (if available).
See the corresponding auspice PR nextstrain/auspice#1152.

Additionally, the logic for setting display_defaults within `augur export v2` is
improved so that we no longer have to define the valid keys in the source code.
Invalid keys are still identified via validating the JSONs against schemas.
@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #561 into master will increase coverage by 2.46%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #561      +/-   ##
==========================================
+ Coverage   19.49%   21.95%   +2.46%     
==========================================
  Files          31       31              
  Lines        5068     5629     +561     
  Branches     1284     1617     +333     
==========================================
+ Hits          988     1236     +248     
- Misses       4057     4292     +235     
- Partials       23      101      +78     
Impacted Files Coverage Δ
augur/export_v2.py 8.04% <0.00%> (+0.04%) ⬆️
augur/parse.py 9.45% <0.00%> (-1.15%) ⬇️
augur/ancestral.py 10.60% <0.00%> (-0.51%) ⬇️
augur/traits.py 8.06% <0.00%> (+0.09%) ⬆️
augur/refine.py 6.41% <0.00%> (+0.89%) ⬆️
augur/import_beast.py 9.27% <0.00%> (+2.52%) ⬆️
augur/align.py 50.88% <0.00%> (+4.26%) ⬆️
augur/clades.py 15.62% <0.00%> (+4.28%) ⬆️
augur/utils.py 32.80% <0.00%> (+5.17%) ⬆️
augur/filter.py 33.80% <0.00%> (+16.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfed26d...7943b2a. Read the comment docs.

@rneher rneher merged commit 2598a05 into master Jun 8, 2020
@trvrb trvrb deleted the display-defaults branch January 11, 2021 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants