Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply snakefmt #187

Merged
merged 1 commit into from
Sep 22, 2023
Merged

chore: apply snakefmt #187

merged 1 commit into from
Sep 22, 2023

Conversation

corneliusroemer
Copy link
Member

No description provided.

@corneliusroemer corneliusroemer merged commit 9fe0536 into master Sep 22, 2023
4 checks passed
@corneliusroemer corneliusroemer deleted the snakefmt branch September 22, 2023 16:54
@victorlin
Copy link
Member

I'm assuming you have local configuration since CI's snakefmt didn't detect anything prior to this PR. Can you push your configuration in a pyproject.toml file?

@corneliusroemer
Copy link
Member Author

Ah, great point! I actually was confused that I needed to specify the folder explicitly and opened an issue snakemake/snakefmt#202

I don't know why this isn't recognized, is it nested too deep? I don't have a pyproject.toml, I had to manually run snakefmt on the file (I saw VS code complain, the plugin is great).

@corneliusroemer
Copy link
Member Author

Ah, we're getting there:

$ snakefmt -vv .
...snip...
[DEBUG] Excluded: ingest/workflow/snakemake_rules/trigger_rebuild.smk matched the --exclude regular expression
...snip...

@corneliusroemer
Copy link
Member Author

Ok this is why:

DEFAULT_EXCLUDES = (
    r"(\.snakemake|\.eggs|\.git|\.hg|\.mypy_cache|\.nox|\.tox|\.venv|\.svn|_build|"
    r"buck-out|build|dist|\.template)"
)

@victorlin
Copy link
Member

Haha yeah, I realized at the same time and commented as snakemake/snakefmt#202 (comment).

@corneliusroemer
Copy link
Member Author

This is a terrible exclude, it matches anything that contains build...

I suggest we start using this in our config: snakefmt -vv --exclude "" .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants