fix: fix the size of the image in CarouselCard component #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 442
💛 - Coveralls |
| const ref = {}; | ||
| expect(carouselCardContainerStyles(ref)).toBeNull(); | ||
| }); | ||
| it('should return an object with a heght of 100% if the parentNode the ref passed has an height set', () => { |
| height: '100%', | ||
| }); | ||
| }); | ||
| it('should return an object with a heght of 340 if the parentNode of the ref passed does not have an height set', () => { |
src/components/CarouselCard/index.js
Outdated
| @@ -5,7 +5,7 @@ import classnames from 'classnames'; | |||
| import { Provider } from './context'; | |||
| import Indicators from './indicators'; | |||
| import AnimationButton from './animationButton'; | |||
| import { getItemIndex, getChildTabNodes, insertChildOrderly } from './utils'; | |||
| import { getItemIndex, getChildTabNodes, insertChildOrderly, carouselCardContainerStyles } from './utils'; | |||
There was a problem hiding this comment.
getContainerStyles since it is a function, would be carouselCardContainerStyles if it were a const.
| <div> | ||
| <img className="rainbow-carousel-image_image" src={src} alt={assistiveText} /> | ||
| <div className="rainbow-carousel-image_content-image-container"> | ||
| <div className="rainbow-carousel-image_image" style={this.getImageSrc()} alt={assistiveText} /> |
There was a problem hiding this comment.
the alt attribute is only for img element so here we need to use the AssistiveText component in order to screen readers take the assistive text. Then:
<div className="rainbow-carousel-image_content-image-container">
<div className="rainbow-carousel-image_image" style={this.getImageSrc()} />
<AssistiveText text={assistiveText} />
</div>
LeandroTorresSicilia
approved these changes
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #408