Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template to v1.7 #52

Merged
merged 30 commits into from Oct 11, 2019
Merged

Update template to v1.7 #52

merged 30 commits into from Oct 11, 2019

Conversation

drpatelh
Copy link
Member

@drpatelh drpatelh commented Oct 10, 2019

Many thanks to contributing to nf-core/atacseq!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/atacseq branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/atacseq/tree/master/.github/CONTRIBUTING.md

  • Add in deepTools and Preseq
  • add --skipAtaqv parameter

@drpatelh drpatelh requested a review from a team October 11, 2019 10:26
@drpatelh
Copy link
Member Author

Tests are passing. Going to merge 👍

@drpatelh drpatelh merged commit a6cdc72 into nf-core:dev Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant