Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important! Template update for nf-core/tools v2.14.1 #120

Merged
merged 8 commits into from
May 10, 2024

Conversation

nf-core-bot
Copy link
Member

Version 2.14.1 of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.

Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the nf-core-template-merge-2.14.1 branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.

For instructions on how to merge this PR, please see https://nf-co.re/docs/contributing/sync/.

For more information about this release of nf-core/tools, please see the v2.14.1 release page.

Copy link

github-actions bot commented May 9, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit eeb35ed

+| ✅ 257 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-05-09 19:36:54

Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to double check the modules.config files, I feel like some of your selectors have disappeared

@nictru
Copy link
Contributor

nictru commented May 10, 2024

This selectors were artifacts, targeting processes which did not exist any more, even before this PR. As far as I can tell, this new version of nf-core/tools is the first one failing the nf-core lint in this situation. I removed them on purpose.

@nictru nictru merged commit 0f10c05 into dev May 10, 2024
4 checks passed
@nictru nictru deleted the nf-core-template-merge-2.14.1 branch May 10, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants