Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SEACR normalization and stringency options #156

Closed
CloXD opened this issue Sep 14, 2022 · 2 comments
Closed

Add SEACR normalization and stringency options #156

CloXD opened this issue Sep 14, 2022 · 2 comments
Labels
enhancement Improvement for existing functionality

Comments

@CloXD
Copy link

CloXD commented Sep 14, 2022

Description of feature

Hello,
I'm working with some Cut and Tag data and with the kit that we are using ( iDEAL Cut&Tag Kit for Histones).
Since there is no spike-in genome in the library, I normalized using the CPM, as suggested in the reference.
Many of the peaks called using SEACR are very weak and the Igg have a signal that is very close to the samples ones.
I guess that in part it's due to the poor quality of the data ( we surely need to improve the library preparation ), but also I noticed that the hard-coded parameters SEACR disable their internal normalization and set the stringency to "stringent". In their github manual, they suggest to disable the normalization if the sample and control are normalized on each other. Since the CPM ( or any of the other methods included in the pipeline ) normalize against the input, I manually tried the internal normalization and the results are much better.
It would be nice to have those parameters explicitly defined in the pipeline.
I already created the repository with the additional parameters and I'm testing them now (https://github.com/CloXD/cutandrun ) as soon as I check that everything works nicely, I'll do the pull request.
Cheers,
Claudio

@CloXD CloXD added the enhancement Improvement for existing functionality label Sep 14, 2022
@chris-cheshire
Copy link
Contributor

Hi, thanks for your suggestion! I have included these changes in the upcoming 3.0 release candidate. Keep an eye out for the announcement in the cutandrun slack channel.

@CloXD
Copy link
Author

CloXD commented Sep 20, 2022

Perfect, glad to help!
Cheers,
Claudio

@CloXD CloXD closed this as completed Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement for existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants