Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final samplesheet is not created when --skip_fastq_download is provided #114

Closed
SchwarzMarek opened this issue Sep 26, 2022 · 2 comments
Closed
Labels
bug Something isn't working
Milestone

Comments

@SchwarzMarek
Copy link

Description of the bug

The --skip_fastq_download flag implies that only the fastq files will not be downloaded. When using the --skip_fastq_download and --nf_core_pipeline rnaseq together, the fastq files are not downloaded (expected), but sample sheet is not created (unexpected).

Command used and terminal output

nextflow run nf-core/fetchngs -profile docker --nf_core_pipeline rnaseq --outdir test --input temp.txt --max_cpus 2 --max_memory 5.GB --skip_fastq_download

Relevant files

temp.txt

System information

N E X T F L O W ~ version 22.04.5
Launching https://github.com/nf-core/fetchngs [nostalgic_meitner] DSL2 - revision: b79cde2 [master]

@SchwarzMarek SchwarzMarek added the bug Something isn't working label Sep 26, 2022
@pinin4fjords
Copy link
Member

pinin4fjords commented Nov 2, 2022

  • 1 following, encountered this today

@drpatelh drpatelh added this to the 1.8 milestone Nov 4, 2022
@drpatelh drpatelh changed the title samplesheet is not created when --skip_fastq_download is given Final samplesheet is not created when --skip_fastq_download is provided Nov 7, 2022
drpatelh added a commit to drpatelh/nf-core-fetchngs that referenced this issue Nov 7, 2022
@drpatelh drpatelh mentioned this issue Nov 7, 2022
@drpatelh
Copy link
Member

drpatelh commented Nov 7, 2022

This will be fixed in #124

A merged samplesheet will now also be generated if using --skip_fastq_download. The only difference will be that the original ftp download links will be populated in the fastq_1 and fastq_2 fields rather than the local paths relative to --outdir where fastq_1 and fastq_2 would have been downloaded if not using --skip_fastq_download. Note, that if the ftp download links don't exist as part of the ENA metadata then the fastq_1 and fastq_2 fields will be empty in the samplesheet but there is nothing we can do about that really.

@drpatelh drpatelh closed this as completed Nov 7, 2022
drpatelh added a commit that referenced this issue Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants