Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Fix editorconfig errors #195

Merged
merged 1 commit into from
Mar 18, 2024
Merged

style: Fix editorconfig errors #195

merged 1 commit into from
Mar 18, 2024

Conversation

edmundmiller
Copy link
Contributor

@edmundmiller edmundmiller commented Mar 8, 2024 •
edited
Loading

Main thing was setting

[*.{nf,cpp}]
indent_size = 2

Which was the style that I found. Not sure how others feel about deviating from the rest of nf-core on the Nextflow style specifically, but I think getting it all in one style first is a good step!

@edmundmiller edmundmiller self-assigned this Mar 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 4c299ae

+| ✅ 185 tests passed       |+
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Create channel from input file provided through params.input
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-03-18 16:06:03

@edmundmiller edmundmiller added this to the version-2.2.0 milestone Mar 8, 2024
@edmundmiller edmundmiller marked this pull request as ready for review March 8, 2024 21:34
@edmundmiller edmundmiller mentioned this pull request Mar 8, 2024
Merged
@CarsonJM
Copy link

@edmundmiller I personally don't mind the change! Would you prefer to get feedback from someone with more experience/knowledge before merging though?

@edmundmiller
Copy link
Contributor Author

Thanks! I think we just merge this, and we can go back to 4 spaces if it causes issues.

Actually, I don't know if this will mess with the template updates 🤔 I think we should go with 4 spaces.

@CarsonJM
Copy link

I have a strong feeling it would mess with template updates haha
So going back to 4 spaces now?

@edmundmiller
Copy link
Contributor Author

Switched to 4 spaces 👍🏻

@edmundmiller edmundmiller merged commit 70f5739 into dev Mar 18, 2024
4 checks passed
@edmundmiller edmundmiller deleted the editorconfig branch March 18, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

@nservant nservant Awaiting requested review from nservant

Assignees

@edmundmiller edmundmiller

Labels
None yet
Projects
None yet
Milestone
version-2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@edmundmiller @CarsonJM @maxulysse